Python ESSA: Fix performance of PythonSsaSourceVariable.hasRefinementEdge()#600
Merged
taus-semmle merged 1 commit intoDec 4, 2018
Conversation
taus-semmle
approved these changes
Dec 4, 2018
taus-semmle
left a comment
taus-semmle
left a comment
Contributor
There was a problem hiding this comment.
Two small questions, but otherwise LGTM.
| } | ||
|
|
||
| override predicate hasRefinementEdge(ControlFlowNode use, BasicBlock pred, BasicBlock succ) { | ||
| test_contains(pred.getLastNode(), use) and |
Contributor
There was a problem hiding this comment.
Compared to what the code did previously, test_contains contains an additional instanceof Expr check. It's not immediately clear to me whether this affects the behaviour. Can you weigh in on this?
Contributor
Author
There was a problem hiding this comment.
The last node in a branching block will always be an Expr. So this doesn't change behaviour, just makes it faster.
| n = this.getAUse() or | ||
| this.hasDefiningNode(n) | | ||
| pred.(ConditionBlock).strictlyReaches(n.getBasicBlock()) | ||
| ) |
Contributor
There was a problem hiding this comment.
Do we know which of these changes -- using test_contains and removing this conjunct -- was responsible for the improvement? Was it both?
Contributor
Author
There was a problem hiding this comment.
Both, but mainly this one, I think.
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Improve "Incorrect integer conversion" query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.